Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

test: remove unnecessary skipIfWorker() #25427

Closed
wants to merge 1 commit into from
Closed

test: remove unnecessary skipIfWorker() #25427

wants to merge 1 commit into from

Conversation

Trott
Copy link
Member

@Trott Trott commented Jan 10, 2019

test-inspector-port-cluster passes in workers. Remove skipIfWorker()
from the test.

Checklist
  • make -j4 test (UNIX), or vcbuild test (Windows) passes
  • commit message follows commit guidelines

@Trott
test: remove unnecessary skipIfWorker()
d41201c 
test-inspector-port-cluster passes in workers. Remove skipIfWorker()
from the test.
@nodejs-github-bot
Copy link
Collaborator

@Trott build started: https://ci.nodejs.org/blue/organizations/jenkins/node-test-pull-request-lite-pipeline/detail/node-test-pull-request-lite-pipeline/2216/pipeline

@nodejs-github-bot nodejs-github-bot added the test Issues and PRs related to the tests. label Jan 10, 2019
@Trott
Copy link
Member Author

Trott commented Jan 10, 2019 •
edited by addaleax
Loading

CI: https://ci.nodejs.org/job/node-test-pull-request/20041/ (:heavy_check_mark:)

@addaleax addaleax added the author ready PRs that have at least one approval, no pending requests for changes, and a CI started. label Jan 10, 2019
Trott added a commit to Trott/io.js that referenced this pull request Jan 12, 2019
@Trott
test: remove unnecessary skipIfWorker()
91ef9c4 
test-inspector-port-cluster passes in workers. Remove skipIfWorker()
from the test.

PR-URL: nodejs#25427
Reviewed-By: Eugene Ostroukhov <eostroukhov@google.com>
Reviewed-By: Ruben Bridgewater <ruben@bridgewater.de>
Reviewed-By: Benjamin Gruenbaum <benjamingr@gmail.com>
Reviewed-By: Colin Ihrig <cjihrig@gmail.com>
Reviewed-By: Luigi Pinca <luigipinca@gmail.com>
@Trott
Copy link
Member Author

Trott commented Jan 12, 2019

Landed in 91ef9c4

@Trott Trott closed this Jan 12, 2019
addaleax pushed a commit that referenced this pull request Jan 14, 2019
@Trott @addaleax
test: remove unnecessary skipIfWorker()
d86a3e8 
test-inspector-port-cluster passes in workers. Remove skipIfWorker()
from the test.

PR-URL: #25427
Reviewed-By: Eugene Ostroukhov <eostroukhov@google.com>
Reviewed-By: Ruben Bridgewater <ruben@bridgewater.de>
Reviewed-By: Benjamin Gruenbaum <benjamingr@gmail.com>
Reviewed-By: Colin Ihrig <cjihrig@gmail.com>
Reviewed-By: Luigi Pinca <luigipinca@gmail.com>
@BridgeAR BridgeAR mentioned this pull request Jan 16, 2019
Merged
BridgeAR pushed a commit to BridgeAR/node that referenced this pull request Jan 16, 2019
@Trott @BridgeAR
test: remove unnecessary skipIfWorker()
e5f88f5 
test-inspector-port-cluster passes in workers. Remove skipIfWorker()
from the test.

PR-URL: nodejs#25427
Reviewed-By: Eugene Ostroukhov <eostroukhov@google.com>
Reviewed-By: Ruben Bridgewater <ruben@bridgewater.de>
Reviewed-By: Benjamin Gruenbaum <benjamingr@gmail.com>
Reviewed-By: Colin Ihrig <cjihrig@gmail.com>
Reviewed-By: Luigi Pinca <luigipinca@gmail.com>
@MylesBorins MylesBorins mentioned this pull request Jan 24, 2019
Merged
BethGriggs pushed a commit that referenced this pull request Apr 28, 2019
@Trott @BethGriggs
test: remove unnecessary skipIfWorker()
ada148d 
test-inspector-port-cluster passes in workers. Remove skipIfWorker()
from the test.

PR-URL: #25427
Reviewed-By: Eugene Ostroukhov <eostroukhov@google.com>
Reviewed-By: Ruben Bridgewater <ruben@bridgewater.de>
Reviewed-By: Benjamin Gruenbaum <benjamingr@gmail.com>
Reviewed-By: Colin Ihrig <cjihrig@gmail.com>
Reviewed-By: Luigi Pinca <luigipinca@gmail.com>
@BethGriggs BethGriggs mentioned this pull request May 1, 2019
Merged
BethGriggs pushed a commit that referenced this pull request May 10, 2019
@Trott @BethGriggs
test: remove unnecessary skipIfWorker()
55899ef 
test-inspector-port-cluster passes in workers. Remove skipIfWorker()
from the test.

PR-URL: #25427
Reviewed-By: Eugene Ostroukhov <eostroukhov@google.com>
Reviewed-By: Ruben Bridgewater <ruben@bridgewater.de>
Reviewed-By: Benjamin Gruenbaum <benjamingr@gmail.com>
Reviewed-By: Colin Ihrig <cjihrig@gmail.com>
Reviewed-By: Luigi Pinca <luigipinca@gmail.com>
MylesBorins pushed a commit that referenced this pull request May 16, 2019
@Trott @MylesBorins
test: remove unnecessary skipIfWorker()
d2df34d 
test-inspector-port-cluster passes in workers. Remove skipIfWorker()
from the test.

PR-URL: #25427
Reviewed-By: Eugene Ostroukhov <eostroukhov@google.com>
Reviewed-By: Ruben Bridgewater <ruben@bridgewater.de>
Reviewed-By: Benjamin Gruenbaum <benjamingr@gmail.com>
Reviewed-By: Colin Ihrig <cjihrig@gmail.com>
Reviewed-By: Luigi Pinca <luigipinca@gmail.com>
This was referenced May 29, 2019
Closed
Closed
Closed
Closed
Closed
@Trott Trott deleted the rm-skipIfWorker branch January 13, 2022 22:50
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@BridgeAR BridgeAR BridgeAR approved these changes

@cjihrig cjihrig cjihrig approved these changes

@lpinca lpinca lpinca approved these changes

@benjamingr benjamingr benjamingr approved these changes

@eugeneo eugeneo eugeneo approved these changes

Assignees
No one assigned
Labels
author ready PRs that have at least one approval, no pending requests for changes, and a CI started. test Issues and PRs related to the tests.
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
8 participants
@Trott @nodejs-github-bot @eugeneo @benjamingr @lpinca @cjihrig @BridgeAR @addaleax